Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] [Data API] Backend refactoring#262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
roaffix wants to merge36 commits intoarrayfire:master
base:master
Choose a base branch
Loading
fromroaffix:feature/backend-refactoring

Conversation

roaffix
Copy link
Contributor

@roaffixroaffix commentedApr 3, 2023
edited
Loading

NOTE: the assumption that this PR will be merged right after the#261

Major changes:

  • Wrapsafe_call(backend.get()...) under thelibrary call which is now used as a private wrapper of the C library. That makes the public part of the library more intuitive for both end-users and library contributors.
  • Wrapctypes underCType which inherits thectypes._SimpleCData type.
  • Project structure changes:
    • C library wrapper moved to the corresponding folder
    • Moved dtype aux functions todtypes/helpers. Also, some methods were transferred there from the array_object file
  • Addedoperators block which is duplicated the functionality of magic methods (like__add__) from the main array object and is required by the specification
  • Changed testing structure to test parameterization and test auto-generation. These solutions decrease somehow an intuition of test cases but simplify the flow of adding new cases - it requires 1 or 2 rows instead of hundreds, now.

Minor changes:

  • Removed some tags (TODO, FIXME, etc.) from the previous PR
  • Removed an introduced in previous PR custom typeShapeType to avoid extra complexion in library typing
  • Other minor code style changes
  • Fixed minor bugs

--- WIP ---

  • backend config separated into pre-setup and backend configuration settings
  • add moreoperators
  • add moretests coverage
  • add mocks for different backend types for even more coverage of different test scenarios
  • fix CI/CD in GitHub for CPU tests

Antonand others added30 commitsJanuary 24, 2023 02:35
@roaffixroaffix changed the title[WIP] Backend refactoring[WIP] [Data API] Backend refactoringApr 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@roaffix

[8]ページ先頭

©2009-2025 Movatter.jp