Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Enum classes and their inheritance#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
roaffix wants to merge1 commit intoarrayfire:dev
base:dev
Choose a base branch
Loading
fromroaffix:fix/enum-variables

Conversation

roaffix
Copy link
Contributor

  • Remove the check forenum import.
    Motivation: check for enum's import error is unnecessary on modern python versions because its built-in library is available with a basic python build version. It is pointless to cover very-very-very situational python builds that could not containenum in it.
  • Remove the C++ style formatting for constants declaration.
    Motivation: FYI,@syurkevi :https://www.python.org/dev/peps/pep-0008/#other-recommendations. Especially example before link that is under "More than one space around an assignment (or other) operator to align it with another" and highlighted"never use more than one space" 🖕 😎
  • Remove wrap forEnum constants with_Enum_Type function.
    Motivation: There is no point to use such a method like_Enum_Type that returns the arg as it is passed into it.
  • to_str is moved to the "library" module to avoid circular import with the "util" module.
    Note: This change does not break the public API because it is still declared in__init__.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@roaffix

[8]ページ先頭

©2009-2025 Movatter.jp