- Notifications
You must be signed in to change notification settings - Fork64
Workaround failure in bench_cg. Evaluate x array early#200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
examples/benchmarks/bench_cg.py Outdated
| @@ -137,11 +138,11 @@ def timeit(calc, iters, args): | |||
| def test(): | |||
| print("\nTesting benchmark functions...") | |||
| A, b, x0 = setup_input(50) # dense A | |||
| A, b, x0 = setup_input(50, 7) # dense A | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you are going to add a new param explicitly, can you change this to be named parameters ? i.e.setup_input(n=50, sparsity=7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done
The bench_cg test was failing to execute on the CUDA backend because two non-linear JIT nodes were being combined and caused the resulting kernel parameter size to go above the threshold. The nodes did not cross the evaluation threshold before hand. This will need to be address upstream.
Upstream issue:arrayfire/arrayfire#2389