- Notifications
You must be signed in to change notification settings - Fork546
if not Win check added#3653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ved1beta wants to merge1 commit intoarrayfire:masterChoose a base branch fromved1beta:3652fix
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for this. We are currently overhauling the Windows installer build process so will be making some more changes and fixes soon including for this issue. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip nvrtc-builtins dependency on Windows
This PR modifies the CMake configuration to handle the nvrtc-builtins library
differently on Windows platforms where the library naming convention differs.
Description
This is a bug fix that addresses the issue with CUDA nvrtc-builtins library
not being found on Windows systems. The root cause is that Windows CUDA toolkit
prepends version information to the library name, making the standard library
search fail.
The changes:
Impact:
This PR can be backported to older versions as it's a build system fix that
doesn't affect the core functionality.
Fixes:#3652
Changes to Users
No changes required for users. This is a build system fix that doesn't affect
the API or functionality. Existing code will continue to work as before.
Checklist