Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

made burstSize changeable#559

Merged
ifilippov merged 1 commit intodevelopfromifilippov/fix1
Feb 25, 2019
Merged

made burstSize changeable#559

ifilippov merged 1 commit intodevelopfromifilippov/fix1
Feb 25, 2019

Conversation

ifilippov
Copy link
Contributor

No description provided.

@gshimansky
Copy link
Contributor

Why is it necessary to haveburstSize andvBurstSize if they both equal32 and "Using vector functions with vBurstSize != burstSize is undefined behaviour"? Are we planning to change them to different values and induce undefined behavior?

@ifilippov
Copy link
ContributorAuthor

If we want honest jitter we need to send 1 packet at a time, not 32 packets.
On the other hand vector functions are limited to 32 packets.
If you have only scalar functionality you can use different values without undefined behavior. The point is that currently we can't even try to change send (and other functions) burst size - it simply will not compile.

@ifilippovifilippov merged commit677d990 intodevelopFeb 25, 2019
@ifilippovifilippov deleted the ifilippov/fix1 branchFebruary 25, 2019 16:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gshimanskygshimanskygshimansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ifilippov@gshimansky

[8]ページ先頭

©2009-2025 Movatter.jp