- Notifications
You must be signed in to change notification settings - Fork386
Avoid blocking in NTPClient::update()#163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mlesniew wants to merge1 commit intoarduino-libraries:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When a NTP request is sent, it may take several milliseconds to retrievethe response. This commit changes the NTPClient::update() behaviour toasynchronous allowing a NTP request to be sent with one update() calland handle the response when it's available, in another call eliminatingactive waiting.This commit also changes the NTPClient::forceUpdate() implementation torely on the logic in NTPClient::update(). However, the behaviour ofthis function does not change from the API user's perspective. It isstill synchronous, it only returns when all processing is complete.
CLAassistant commentedJan 28, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
Memory usage change @3f9957d
Click for full report table
Click for full report CSV |
AmirHmZz commentedOct 13, 2023
Any updates on this? |
I believe this PR is ready to be merged, we're just waiting for one of the maintainers to accept it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a NTP request is sent, it may take several milliseconds to retrieve the response. This commit changes the NTPClient::update() behaviour to asynchronous allowing a NTP request to be sent with one update() call and handle the response when it's available in another call, eliminating active waiting.
This commit also changes the NTPClient::forceUpdate() implementation to rely on the logic in NTPClient::update(). However, the behaviour of this function does not change from the API user's perspective. It is still synchronous, it only returns when all processing is complete.
This fixes issue#112.
Note that this is equivalent to what was suggested in PR#90. I decided to reimplement it, because the other PR seems to be forgotten by the author and he still hasn't signed the CLA.