increase time accuracy to not above 100ms    complete decimal part of NTP    use high-freq polling    add _current_epoc_dec and get_millis() so that ms can be knownrewrite update()    solved overflow problem    change update()'s return type to byte in order to carry more info    add a not-request-too-fast feature by adding _last_fail in update()

In addition this PR fixes some spelling and white space issues of the original PR and refactors the new example to look more idiomatic as compared to the existing examples.

CI passes and I compiled all examples for NodeMCU and tested on actual hardware.

WhymustIhaveanameand others added4 commits

May 26, 2021 20:54

change a lots

1c77e16

Add files via upload

4a2c617

Add files via upload

1d64f94

Adds support for fractional seconds

e4d04dd

* Rebases WhymustIhaveaname:master to arduino-libraries:master.* Fixes issues with Spell Check action.* Fixes HiRes example compilation.* Refactors HiRes example to be more idiomatic as compared to the  existing examples.* Fixes several line ending and white space inconsistencies.

Copy link

CLAassistant commentedMay 26, 2021•
edited
Loading

All committers have signed the CLA.

Copy link

github-actionsbot commentedMay 27, 2021

Memory usage change @e4d04dd

Board	flash	%	RAM for global variables	%
esp8266:esp8266:huzzah	🔺 +1744 - +1744	+0.17 - +0.17	🔺 +192 - +192	+0.23 - +0.23

Click for full report table

Board	examples/Advanced flash	%	examples/Advanced RAM for global variables	%	examples/Basic flash	%	examples/Basic RAM for global variables	%	examples/HiRes flash	%	examples/HiRes RAM for global variables	%	examples/IsTimeSet flash	%	examples/IsTimeSet RAM for global variables	%
esp8266:esp8266:huzzah	1744	0.17	192	0.23	1744	0.17	192	0.23	N/A	N/A	N/A	N/A	1744	0.17	192	0.23

Click for full report CSV

Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/HiRes<br>flash,%,examples/HiRes<br>RAM for global variables,%,examples/IsTimeSet<br>flash,%,examples/IsTimeSet<br>RAM for global variables,%esp8266:esp8266:huzzah,1744,0.17,192,0.23,1744,0.17,192,0.23,N/A,N/A,N/A,N/A,1744,0.17,192,0.23

Copy link

chudsaviet commentedAug 29, 2021

Hi, any progress on merging this?

Copy link

Author

tickelton commentedAug 30, 2021

@chudsaviet I haven't received any feedback on this PR, and frankly by now I no longer have any use for it because I implemented an NTP client for the project I was working on from scratch to address this and a couple of other requirements I had that the NTPClient project seemed reluctant to address.