Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Addconfig parameter to RS485 initialization#27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
svollenweider wants to merge2 commits intoarduino-libraries:main
base:main
Choose a base branch
Loading
fromsvollenweider:main

Conversation

svollenweider
Copy link

@svollenweidersvollenweider commentedJan 3, 2025
edited
Loading

Dear all

I recently updated my projects to the new repository. When using RS485, I noticed that there is no option to set the UART Config. This PR adds this option back in.

Copy link
Contributor

@leonardocavagnisleonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for contributing! 😄
This should resolve the compilation issue.

Could you please also update theRS485_fullduplex andRS485_halfduplex examples to include theconfig parameter?

@@ -17,7 +17,7 @@ RS485CommClass::RS485CommClass(arduino::UART& uart_itf, PinName rs_tx_pin, PinNa
RS485CommClass::~RS485CommClass()
{ }

void RS485CommClass::begin(unsigned long baudrate, int predelay, int postdelay) {
void RS485CommClass::begin(unsigned long baudrate,uint16_t config = SERIAL_8N1,int predelay, int postdelay) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
voidRS485CommClass::begin(unsignedlong baudrate,uint16_t config = SERIAL_8N1,int predelay,int postdelay) {
voidRS485CommClass::begin(unsignedlong baudrate,uint16_t config,int predelay,int postdelay) {

@leonardocavagnisleonardocavagnis changed the titleAllow for Config of RS485 againAddconfig parameter to RS485 initializationJan 7, 2025
@leonardocavagnisleonardocavagnis added type: enhancementProposed improvement status: changes requestedChanges to PR are required before merge topic: codeRelated to content of the project itself labelsJan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@leonardocavagnisleonardocavagnisleonardocavagnis requested changes

Assignees
No one assigned
Labels
status: changes requestedChanges to PR are required before mergetopic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@svollenweider@leonardocavagnis

[8]ページ先頭

©2009-2025 Movatter.jp