Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix for knob press#32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Rocketct wants to merge7 commits intoarduino-libraries:joystick
base:joystick
Choose a base branch
Loading
fromRocketct:knob

Conversation

Rocketct
Copy link

this change with the fps fix resolve the#20 issue, call the update before the get or is pressed allows to avoid false negative reading from the i2s bus

@leonardocavagnis
Copy link
Contributor

@Rocketct LGTM :)

Please, could you addupdate() function to theapi.md document?
https://github.com/arduino-libraries/Modulino/blob/main/docs/api.md#modulinoknob

@sebromero
Copy link
Contributor

I suggest to move the whole API documentation to the header file and use the GH action that I created to render the API docs automatically:https://github.com/arduino/render-docs-github-action

leonardocavagnis reacted with heart emoji

@Rocketct
Copy link
Author

@leonardocavagnis done added last fix you can test on yours side and then merge?

leonardocavagnis reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@facchinmfacchinmAwaiting requested review from facchinm

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Rocketct@leonardocavagnis@sebromero@per1234@facchinm
[8]ページ先頭
©2009-2025 Movatter.jp