- Notifications
You must be signed in to change notification settings - Fork20
added support for deadzone on joystick due to rest position drift#27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
facchinm requested changesApr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One small nitpick to just returnfalse
on values that are not exactly the same but inside the deadzone area
Uh oh!
There was an error while loading.Please reload this page.
facchinm approved these changesApr 16, 2025
060556e
intoarduino-libraries:joystick 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
facchinm pushed a commit that referenced this pull requestAug 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Added support for deadzone on joystick due to rest position drift,, this will allows to set the deadzone threshold expressed as ADC levels.
In accord with these changes, the deadzone defines a region of space, where the joystick position is returned as (0,0) in range:
This region can be identified as a square over the rest position of the stick.
changing the dz_threshold change the size of the space of where the value is approximated to (x,y) = (0,0)