This repository was archived by the owner on Feb 28, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork29
Fix voltage reference in examples#94
Merged
leonardocavagnis merged 1 commit intoarduino-libraries:masterfromromainreignier:fix_voltage_referenceSep 21, 2023
Merged
Fix voltage reference in examples#94
leonardocavagnis merged 1 commit intoarduino-libraries:masterfromromainreignier:fix_voltage_referenceSep 21, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The MachineControl boards features a REF3330 3.0 V Reference Voltage.
CLAassistant commentedAug 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Memory usage change @493324e
Click for full report table
Click for full report CSV
|
The patch looks correct.@Rocketct would you mind taking some more measurement on a production board and eventually merge? Thx |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
topic: documentationRelated to documentation for the project type: imperfectionPerceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MachineControl boards features a REF3330 3.0 V Reference Voltage.
As mentioned in this#70 (comment)
I have compared the 0-10V input results with an oscilloscope and the values with the 3.3 V reference were wrong but correct with 3.0 V.