This repository was archived by the owner on Feb 28, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork29
Fix hour alarm register#108
Merged
leonardocavagnis merged 1 commit intoarduino-libraries:masterfrommarqdevx:hour_alarm_fixSep 21, 2023
Merged
Fix hour alarm register#108
leonardocavagnis merged 1 commit intoarduino-libraries:masterfrommarqdevx:hour_alarm_fixSep 21, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: Hamza-Proline <h.benabdeljawed@arduino.cc>
Memory usage change @ffb18f7
Click for full report table
Click for full report CSV |
leonardocavagnis approved these changesSep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@marqdevx,
Thanks for contribution. The fix is correct.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the function
setHourAlarmthe register used wasPCF8563T_HOUR_REGinstead ofPCF8563T_HOUR_ALARM_REG