Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Ethernet support for Portenta + Ethernet Shield#81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pennam merged 16 commits intoarduino-libraries:masterfrompennam:portenta-eth
Nov 3, 2022

Conversation

pennam
Copy link
Contributor

This PR is based on#41 and#70 and adds ethernet support for Portenta H7. In order to get Ethernet connectivity the vision shield needs to be connected.

Since there is plenty of flash available for Portenta, Ethernet connectivity is always included in the build together with WiFi support.

Ci is failing because static IP configuration is based on thisarduino/ArduinoCore-mbed#526

Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍 Good extension of previously laid out pattern 🙇

NetworkConnectionState EthernetConnectionHandler::update_handleInit()
{
if (Ethernet.hardwareStatus() == EthernetNoHardware) {
#if !defined(__AVR__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This comment is not explicitly targeted on this PR. But since AVR is not and will not be supported on Arduino IoT Cloud (its not technically feasible), you can drop all those#if !defined(__AVR__)statements.

@pennam
Copy link
ContributorAuthor

@manchoz i've updated the PR. This should fix also the reconnection issue. Would you give it a spin?

manchoz reacted with thumbs up emoji

@manchoz
Copy link
Contributor

👋@pennam it works perfectly!

LGTM

@github-actions
Copy link

Memory usage change @2462ec0

Boardflash%RAM for global variables%
arduino:mbed:envie_m7🔺 +1896 - +1896+0.24 - +0.24🔺 +288 - +288+0.06 - +0.06
arduino:mbed_nano:nanorp2040connect🔺 +4 - +40.0 - 0.0🔺 +4 - +40.0 - 0.0
arduino:mbed_nicla:nicla_vision0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:samd:mkr1000💚 -8 - -8-0.0 - -0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrgsm1400🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrnb1500🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrwan1300🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrwan1310🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrwifi1010🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:nano_33_iot🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
esp32:esp32:esp320 - 00.0 - 0.0🔺 +8 - +80.0 - 0.0
esp8266:esp8266:huzzah🔺 +16 - +160.0 - 0.00 - 00.0 - 0.0
Click for full report table
Boardexamples/ConnectionHandlerDemo
flash		%examples/ConnectionHandlerDemo
RAM for global variables		%
arduino:mbed:envie_m718960.242880.06
arduino:mbed_nano:nanorp2040connect40.040.0
arduino:mbed_nicla:nicla_vision00.000.0
arduino:samd:mkr1000-8-0.040.01
arduino:samd:mkrgsm140080.040.01
arduino:samd:mkrnb150080.040.01
arduino:samd:mkrwan130080.040.01
arduino:samd:mkrwan131080.040.01
arduino:samd:mkrwifi101080.040.01
arduino:samd:nano_33_iot80.040.01
esp32:esp32:esp3200.080.0
esp8266:esp8266:huzzah160.000.0
Click for full report CSV
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%arduino:mbed:envie_m7,1896,0.24,288,0.06arduino:mbed_nano:nanorp2040connect,4,0.0,4,0.0arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0arduino:samd:mkr1000,-8,-0.0,4,0.01arduino:samd:mkrgsm1400,8,0.0,4,0.01arduino:samd:mkrnb1500,8,0.0,4,0.01arduino:samd:mkrwan1300,8,0.0,4,0.01arduino:samd:mkrwan1310,8,0.0,4,0.01arduino:samd:mkrwifi1010,8,0.0,4,0.01arduino:samd:nano_33_iot,8,0.0,4,0.01esp32:esp32:esp32,0,0.0,8,0.0esp8266:esp8266:huzzah,16,0.0,0,0.0

@pennam
Copy link
ContributorAuthor

@manchoz@aentinger sorry to bother you again with this PR. I have done some changes :

1026b98 Since eth connection is available on multiple boards for portenta (breakout, machine control...) it makes no reason to add a specific define for each one.

1f3b9a5subnet is not the correct name to use so i've renamed it intonetmask.

b53dd95 This one is to be able to create a simpler template for cloud sketches.

2462ec0 And this is for const correctness

Copy link
Contributor

@manchozmanchoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@aentinger
Copy link
Contributor

LGTM 👍

@github-actions
Copy link

Memory usage change @4e68980

Boardflash%RAM for global variables%
arduino:mbed:envie_m7🔺 +1808 - +1808+0.23 - +0.23🔺 +376 - +376+0.07 - +0.07
arduino:mbed_nano:nanorp2040connect🔺 +4 - +40.0 - 0.0🔺 +4 - +40.0 - 0.0
arduino:mbed_nicla:nicla_vision0 - 00.0 - 0.00 - 00.0 - 0.0
arduino:samd:mkr1000💚 -8 - -8-0.0 - -0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrgsm1400🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrnb1500🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrwan1300🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrwan1310🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:mkrwifi1010🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
arduino:samd:nano_33_iot🔺 +8 - +80.0 - 0.0🔺 +4 - +4+0.01 - +0.01
esp32:esp32:esp320 - 00.0 - 0.0🔺 +8 - +80.0 - 0.0
esp8266:esp8266:huzzah🔺 +16 - +160.0 - 0.00 - 00.0 - 0.0
Click for full report table
Boardexamples/ConnectionHandlerDemo
flash		%examples/ConnectionHandlerDemo
RAM for global variables		%
arduino:mbed:envie_m718080.233760.07
arduino:mbed_nano:nanorp2040connect40.040.0
arduino:mbed_nicla:nicla_vision00.000.0
arduino:samd:mkr1000-8-0.040.01
arduino:samd:mkrgsm140080.040.01
arduino:samd:mkrnb150080.040.01
arduino:samd:mkrwan130080.040.01
arduino:samd:mkrwan131080.040.01
arduino:samd:mkrwifi101080.040.01
arduino:samd:nano_33_iot80.040.01
esp32:esp32:esp3200.080.0
esp8266:esp8266:huzzah160.000.0
Click for full report CSV
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%arduino:mbed:envie_m7,1808,0.23,376,0.07arduino:mbed_nano:nanorp2040connect,4,0.0,4,0.0arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0arduino:samd:mkr1000,-8,-0.0,4,0.01arduino:samd:mkrgsm1400,8,0.0,4,0.01arduino:samd:mkrnb1500,8,0.0,4,0.01arduino:samd:mkrwan1300,8,0.0,4,0.01arduino:samd:mkrwan1310,8,0.0,4,0.01arduino:samd:mkrwifi1010,8,0.0,4,0.01arduino:samd:nano_33_iot,8,0.0,4,0.01esp32:esp32:esp32,0,0.0,8,0.0esp8266:esp8266:huzzah,16,0.0,0,0.0

@pennampennam changed the titleAdd Ethernet support for Portenta + Vision ShieldAdd Ethernet support for Portenta + Ethernet ShieldNov 2, 2022
@pennampennam merged commit04af28b intoarduino-libraries:masterNov 3, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@manchozmanchozmanchoz approved these changes

@aentingeraentingeraentinger approved these changes

@facchinmfacchinmAwaiting requested review from facchinm

Assignees
No one assigned
Labels
topic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pennam@manchoz@aentinger@per1234
[8]ページ先頭
©2009-2025 Movatter.jp