- Notifications
You must be signed in to change notification settings - Fork37
Added Example and Bug fixes on Ethernet#70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
gannaramu wants to merge2 commits intoarduino-libraries:ethernetChoose a base branch
base:ethernet
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CLAassistant commentedOct 21, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
| @@ -28,11 +31,18 @@ GSMConnectionHandler conMan(SECRET_APN, SECRET_PIN, SECRET_GSM_USER, SECRET_GSM_ | |||
| NBConnectionHandler conMan(SECRET_PIN); | |||
| #elif defined(BOARD_HAS_LORA) | |||
| LoRaConnectionHandler conMan(SECRET_APP_EUI, SECRET_APP_KEY); | |||
| #elif defined(BOARD_HAS_ETHERNET) | |||
| byte mac[] = { 0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED }; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The Teensy 4.0 and 4.1 have a built-in MAC address that should be used instead. Perhaps a board check here is appropriate.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: codeRelated to content of the project itself topic: documentationRelated to documentation for the project type: enhancementProposed improvement type: imperfectionPerceived defect in any part of project
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I have a use case for my research where I am trying to use the ArduinoIOTCloud library on a Teensy 4.0 with an ATECC608A along with a Wiznet Ethernet Module. I was able to get the modified example to work on it and get a "CONNECTED to network" on the serial monitor.