Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support for WPA2 Enterprise#65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jesmith-all wants to merge3 commits intoarduino-libraries:master
base:master
Choose a base branch
Loading
frombrownby:master

Conversation

jesmith-all
Copy link

  • Adds optional argument to WifiConnectionHandler constructor to pass a username
  • Conditional in .cpp checks if value has been set, calls on .begin or .beginEnterprise accordingly
  • Critical to use at universities
  • If merged, would allow students on university networks to use IoT Cloud without modifying a local copy of the library

…ditional to substitute Wifi.beginEnterprise method() when modified from default value.
@CLAassistant
Copy link

CLAassistant commentedAug 9, 2021•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@facchinm
Copy link
Contributor

Hi@jesmith-all ,
thanks for the PR! However, the API is a bit confusing IMO; I'd prefer a derived class similar to#63 that could be "selected" by the user as soon asarduino-libraries/ArduinoIoTCloud#265 get merged and the online "stub" generator updated.
This would allow callingbeginEnterprise() with all the different options (like entity/ca if needed).

@jesmith-all
Copy link
Author

@facchinm (@brownby)

Fair enough. With an active course now and more around the corner, I sought the path of least resistance in edits that would add the functionality as a stop gap, but you're right that this isn't as clean as it could be.

I have not been tracking these other developments, but it's great to hear that you've got a vision for how things could coalesce. I'll take a look and circle back.

@per1234per1234 added type: enhancementProposed improvement topic: codeRelated to content of the project itself status: changes requestedChanges to PR are required before merge labelsMay 15, 2022
@per1234per1234 linked an issueMay 15, 2022 that may beclosed by this pull request
@olipinski
Copy link

@facchinm Does it still need to be in a derived class? I see that the project file structure has changed quite a bit since this PR, but if it still needs to be a separate class, I can give it a go.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: changes requestedChanges to PR are required before mergetopic: codeRelated to content of the project itselftype: enhancementProposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WiFi Handler for WPA2 Enterprise networks
5 participants
@jesmith-all@CLAassistant@facchinm@olipinski@per1234
[8]ページ先頭
©2009-2025 Movatter.jp