arduino-libraries/Arduino_ConnectionHandlerPublic

NotificationsYou must be signed in to change notification settings
Fork37
Star100

Add Opta Cellular as possible connection source for Arduino Opta#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

maidnl wants to merge4 commits intoarduino-libraries:master

base:master

Choose a base branch

frommaidnl:opta_cellular_dev

Open

Add Opta Cellular as possible connection source for Arduino Opta#133

maidnl wants to merge4 commits intoarduino-libraries:masterfrommaidnl:opta_cellular_dev

Conversation

Copy link

maidnl commentedJan 28, 2025

This PR introduce Arduino Opta Cellular as possible connection source for Arduino Opta

maidnl added2 commits

January 28, 2025 17:18

introducing Cellular possibility on Connection Handler Demo

0f21423

Introducing Arduino Opta Cellular as possible connection source for A…

502e12d

…rduino Opta

maidnl requested review fromandreagilardoni,facchinm andpennam

January 28, 2025 16:22

andreagilardoni reviewed

Jan 28, 2025

View reviewed changes

src/CellularConnectionHandler.cpp OutdatedShow resolvedHide resolved

Copy link

github-actionsbot commentedJan 28, 2025

Memory usage change @502e12d

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1310`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ConnectionHandlerDemo` flash	%	`examples/ConnectionHandlerDemo` RAM for global variables	%	`examples/ConnectionHandlerDemo-Notecard` flash	%	`examples/ConnectionHandlerDemo-Notecard` RAM for global variables	%
`arduino:esp32:nano_nora`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1310`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%arduino:esp32:nano_nora,0,0.0,0,0.0,0,0.0,0,0.0arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0

per1234 added type: enhancement

Proposed improvement

topic: codeRelated to content of the project itself labels

Jan 29, 2025

Update src/CellularConnectionHandler.cpp

5e782a9

removed redundant preprocessor #if definedCo-authored-by: Andrea Gilardoni <4046444+andreagilardoni@users.noreply.github.com>

Copy link

github-actionsbot commentedJan 29, 2025

Memory usage change @5e782a9

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1310`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ConnectionHandlerDemo` flash	%	`examples/ConnectionHandlerDemo` RAM for global variables	%	`examples/ConnectionHandlerDemo-Notecard` flash	%	`examples/ConnectionHandlerDemo-Notecard` RAM for global variables	%
`arduino:mbed_nano:nanorp2040connect`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1310`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0

andreagilardoni approved these changes

Jan 29, 2025

View reviewed changes

handled the case the Opta Cellular is not present

a94ac93

If the Opta Cellular is not present the Opta crashed due to some impossible communication or timeout in the _cellular.unlockSIM()function callWith this change if the Cellular is not present no useless call to _cellular.unlockSIM() is performed and this prevent the crash

Copy link

github-actionsbot commentedJan 31, 2025

Memory usage change @a94ac93

Board	flash	%	RAM for global variables	%
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1310`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`esp8266:esp8266:huzzah`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ConnectionHandlerDemo-Notecard` flash	%	`examples/ConnectionHandlerDemo-Notecard` RAM for global variables	%
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0
`arduino:samd:mkr1000`	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0
`arduino:samd:mkrwan1310`	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0
`esp8266:esp8266:huzzah`

Click for full report CSV

Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0esp8266:esp8266:huzzah,0,0.0,0,0.0,,,,