- Notifications
You must be signed in to change notification settings - Fork82
Deferred OTA#281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Deferred OTA#281
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Memory usage change @c7945c6
Click for full report table
Click for full report CSV
|
codecov-commenter commentedOct 22, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #281 +/- ##======================================= Coverage 95.31% 95.31% ======================================= Files 25 25 Lines 896 896 ======================================= Hits 854 854 Misses 42 42 Continue to review full report at Codecov.
|
Memory usage change @5436c05
Click for full report table
Click for full report CSV
|
Sending back to the cloud the cleared ArduinoIoTCloud/src/property/Property.h Line 216 in5e19f33
onOTARequest() function to clear the_ota_req after it and then added a dedicated function to reset the board. |
Memory usage change @e4ce494
Click for full report table
Click for full report CSV
|
Force pushed because i've found an easier solution |
Memory usage change @9cf7523
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍 A couple of suggestions concerning naming and overall code consistency.
examples/ArduinoIoTCloud-DeferredOTA/ArduinoIoTCloud-DeferredOTA.ino OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Thanks@aentinger i will definitely implement your suggestions to avoid code style mish mash and improve clarity. |
Memory usage change @9ac60f8
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍 Thank you for your changes 👍
… updates check and fail to update the cloud
rebased on master |
Uh oh!
There was an error while loading.Please reload this page.
@facchinm i've took your PR#265 and made some small changes:
_ota_req
variable with the cloud and be able to start a deferred OTA after a board reset.Having this feature has some minor drawbacks:
onOTARequestCb()
will be called again even if the OTA update was already applied.Tests:
WebIDE OTA:
arduino-cloud-cli deferred OTA:
./arduino-cloud-cli ota upload --device-id xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx --file filename.ino.bin --deferred
/cc@eclipse1985@manchoz