- Notifications
You must be signed in to change notification settings - Fork171
ContentLength can go over 2 byte int#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Converted int to long to allow for more then 65535 bytes in length
Converted int to long to allow for more then 65535 bytes in length
salexander2 commentedNov 2, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi, is necessary to adjust also the sendHeader metod: sendHeader(const char* aHeaderName, constint aHeaderValue); |
As the const char is pointing to a real string (the value of a header in this case). I think that would be incorrect. |
salexander2 commentedNov 3, 2020
Hi, please check. |
I think casting your value to int would do the trick as the method already exists: ArduinoHttpClient/src/HttpClient.h Line 198 in0fac9f0
|
salexander2 commentedNov 3, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
If you try to use this method passing a "long" value, it will not work. I tried, and I received a timeout error. |
Do you have a simple example? I think i miss something. |
salexander2 commentedNov 4, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have my project, that is not so simple....
Here, if I leave the parameter of sendHeader as int, the upload fails with a timeout, and errorcode -3. If I convert int to long it works. I'm available with TeamViewer, if you want to see. Alessandro |
admindotnu commentedJan 18, 2021
Any reasson why this request is not merged yet ? |
CLAassistant commentedApr 9, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
andreagilardoni commentedMar 21, 2024
Hi@Park0, thanks for your contribution, could you please sign the CLA? |
When i tried to download a file over 64k i got issues on a arduinomega. This change will make the content length of type long so it will be 4 bytes.