forked fromamcewen/HttpClient
- Notifications
You must be signed in to change notification settings - Fork171
Using ServerAddress for Host header#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
lehecka wants to merge2 commits intoarduino-libraries:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CLAassistant commentedApr 9, 2021
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HttpClient can be initialized with a ServerName(string) or ServerAddress (IPAddress). In the first case the underlaying Client will use DNS lookup to translate the name to the IP address. This lookup code is consuming extra bytes in memory. When making the HTTP request the ServerName is used for Host header.
If the ServerAddress is specified in the ctor of the HttpClient then the HTTP requests are missing the Host header.
In this diff the user has ability to call useServerAddressForHostHeader to use the ServerAddress for the Host header.
As a workaround without this fix one has to use sendHeader / beginBody / endRequest call which makes the API use very cumbersome and error prone .