- Notifications
You must be signed in to change notification settings - Fork171
Fix -Wlogical-not-parentheses warning#79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The warning occurs because `operator!()` has higher precedence than `operator>()`.Alternatively, we can use:```iClient->connect(iServerAddress, iServerPort) <= 0```
semcneil left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This fix worked for me as well. Can it be merged?
FedeBev commentedJun 5, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi there, what about this? |
xxthunder left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be merged.
Uh oh!
There was an error while loading.Please reload this page.
Hello, the above warning is issued forlines 87 and97. I believe the warning occurs because
operator!()
has higher precedence thanoperator>()
.Alternatively, we can use: