Add standard HTTP CODE Errors in HttpClient.h#65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Warlib1975 wants to merge1 commit intoarduino-libraries:master

base:master

Choose a base branch

fromWarlib1975:patch-3

Open

Add standard HTTP CODE Errors in HttpClient.h#65

Warlib1975 wants to merge1 commit intoarduino-libraries:masterfromWarlib1975:patch-3

Conversation

Copy link

Warlib1975 commentedApr 23, 2019

RFC7231 error code definitions

Update HttpClient.h

d80a5b5

RFC7231 error code definitions

Warlib1975 changed the title~~Update HttpClient.h~~Add standard HTTP CODE Errors in HttpClient.h

Apr 23, 2019

sandeepmistry reviewed

Apr 25, 2019

View reviewed changes

src/HttpClient.h

		@@ -38,6 +38,68 @@ static const int HTTP_ERROR_INVALID_RESPONSE =-4;
		#define HTTP_HEADER_USER_AGENT "User-Agent"
		#define HTTP_HEADER_VALUE_CHUNKED "chunked"

		// HTTP codes see RFC7231
		typedef enum {
		HTTP_CODE_CONTINUE = 100,

Copy link

sandeepmistryApr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer the prefix to beHTTP_STATUS_CODE_ instead ofHTTP_CODE_ here.

Copy link

CLAassistant commentedApr 9, 2021

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}