forked fromamcewen/HttpClient
- Notifications
You must be signed in to change notification settings - Fork171
Fix incorrect return value, resulting in compilation error, being there for 8 years!#49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
sandeepmistry merged 1 commit intoarduino-libraries:masterfromforGGe:fix_retarded_http_client_function_returning_voidJan 2, 2019
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Error in question:ArduinoHttpClient/src/HttpClient.h: In member function 'virtual void HttpClient::flush()':ArduinoHttpClient/src/HttpClient.h:310:50: error: return-statement with a value, in function returning 'void' [-fpermissive]
facchinm commentedJan 2, 2019
ESP team arbitrarily changed the signature of |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error in question:
Now this one really pissed me off. It is not the error itself, but a fact that this was ignored from the first time it was uploaded to GitHub:
...ANDESP team was knowing about it and no one give a single bit of effort porting that change into mainstream. Despite hundreds of people using arduino ecosystem and this lib.
It looks even more retarded , that avr-gcc let it pass trough.
Notes for future: please add CI here with grain of static analysis tool. It is not that hard.