forked fromamcewen/HttpClient
- Notifications
You must be signed in to change notification settings - Fork171
Fix size deltas report infrastructure configuration#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This reverts commit7a6b39a.
The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regularexpression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow.The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow wasadjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's"actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was"sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in theartifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longerbeing generated by the workflow.Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use amore strict regular expression. This will make it easier for maintainers and contributors to understand that this valueis a regular expression and the exact nature of how that regular expression functions (which is less clear when relyingon the "arduino/report-size-deltas" action's partial pattern matching behavior).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: infrastructureRelated to project infrastructure type: imperfectionPerceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed information and reasoning provided by@per1234 can be found here:arduino-libraries/ArduinoIoTCloud#430 .