Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix size deltas report infrastructure configuration#174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 2 commits intomasterfromfix-compile-examples
Feb 21, 2024

Conversation

aentinger
Copy link

Detailed information and reasoning provided by@per1234 can be found here:arduino-libraries/ArduinoIoTCloud#430 .

The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regularexpression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow.The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow wasadjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's"actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was"sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in theartifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longerbeing generated by the workflow.Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use amore strict regular expression. This will make it easier for maintainers and contributors to understand that this valueis a regular expression and the exact nature of how that regular expression functions (which is less clear when relyingon the "arduino/report-size-deltas" action's partial pattern matching behavior).
@aentingeraentinger added type: imperfectionPerceived defect in any part of project topic: infrastructureRelated to project infrastructure labelsFeb 21, 2024
@aentingeraentinger self-assigned thisFeb 21, 2024
@aentingeraentinger merged commit680f815 intomasterFeb 21, 2024
@aentingeraentinger deleted the fix-compile-examples branchFebruary 21, 2024 18:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@aentingeraentinger

Labels
topic: infrastructureRelated to project infrastructuretype: imperfectionPerceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@aentinger

[8]ページ先頭

©2009-2025 Movatter.jp