forked fromamcewen/HttpClient
- Notifications
You must be signed in to change notification settings - Fork171
Added Url parser#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
andreagilardoni merged 9 commits intoarduino-libraries:masterfromandreagilardoni:url-parserMar 21, 2024
Merged
Added Url parser#173
andreagilardoni merged 9 commits intoarduino-libraries:masterfromandreagilardoni:url-parserMar 21, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Memory usage change @a1a79a5
Click for full report table
Click for full report CSV |
per1234 requested changesFeb 24, 2024
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: per1234 <accounts@perglass.com>
Memory usage change @734f5b5
Click for full report table
Click for full report CSV |
per1234 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please put the externally maintained code in a dedicated folder (e.g.,src/utility/URLParser. This will facilitate updates and maintenance. With the current approach of putting the files in a general purposeutility folder, it is likely to get mixed with various other files that are either bespoke or else from other external sources.
Please add aREADME.md file to the folder that documents the upstream source in order to facilitate updates and allow bug fixes and feature requests to be directed to the appropriate project.
Memory usage change @9ea6ace
Click for full report table
Click for full report CSV |
per1234 approved these changesMar 14, 2024
per1234 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@andreagilardoni!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.