NotificationsYou must be signed in to change notification settings
Fork220
Star331

Rewrite handleAclDataPkt to correctly handle fragments#401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

swnf wants to merge1 commit intoarduino-libraries:master

base:master

Choose a base branch

fromswnf:fix-acl-parser

Open

Rewrite handleAclDataPkt to correctly handle fragments#401

swnf wants to merge1 commit intoarduino-libraries:masterfromswnf:fix-acl-parser

Conversation

Copy link

swnf commentedJun 20, 2025

I've noticed that sometimes my BLE connection is interrupted because of a "Rejecting packet cid" error when I send many fragmented packets. I suspect this issue to be caused by the following line:

ArduinoBLE/src/utility/HCI.cpp

Line 730 in9263b3a

if ((aclHdr->dlen -4) != aclHdr->len) {

I don't think a fragment has a L2CAP header. Therefore, thelen field points to arbitrary data. Sometimes it matches the the value in the condition and the packet is misinterpreted (and causes the CID error).

This MR rewrites thehandleAclDataPkt method to be more readable and produce more user-friendly debug output.

Rewrite handleAclDataPkt to correctly handle fragments

f6c5238

Copy link

codecovbot commentedJun 20, 2025

Codecov Report

Attention: Patch coverage is6.66667% with28 lines in your changes missing coverage. Please review.

Project coverage is 15.30%. Comparing base(9263b3a) to head(f6c5238).

Files with missing lines	Patch %	Lines
src/utility/HCI.cpp	6.66%	28 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##           master     #401      +/-   ##==========================================- Coverage   15.30%   15.30%   -0.01%==========================================  Files          28       28                Lines        3666     3673       +7     ==========================================+ Hits          561      562       +1- Misses       3105     3111       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actionsbot commentedJun 20, 2025

Memory usage change @f6c5238

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	💚 -36 - -36	-0.0 - -0.0	0 - 0	0.0 - 0.0
`arduino:megaavr:uno2018:mode=on`	💚 -8 - -8	-0.02 - -0.02	🔺 +1 - +1	+0.02 - +0.02
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	💚 -40 - -32	-0.02 - -0.01	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	💚 -40 - -32	-0.02 - -0.01	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/Central/LedControl` flash	%	`examples/Central/LedControl` RAM for global variables	%	`examples/Central/PeripheralExplorer` flash	%	`examples/Central/PeripheralExplorer` RAM for global variables	%	`examples/Central/Scan` flash	%	`examples/Central/Scan` RAM for global variables	%	`examples/Central/ScanCallback` flash	%	`examples/Central/ScanCallback` RAM for global variables	%	`examples/Central/SensorTagButton` flash	%	`examples/Central/SensorTagButton` RAM for global variables	%	`examples/Peripheral/Advertising/EnhancedAdvertising` flash	%	`examples/Peripheral/Advertising/EnhancedAdvertising` RAM for global variables	%	`examples/Peripheral/Advertising/RawDataAdvertising` flash	%	`examples/Peripheral/Advertising/RawDataAdvertising` RAM for global variables	%	`examples/Peripheral/BatteryMonitor` flash	%	`examples/Peripheral/BatteryMonitor` RAM for global variables	%	`examples/Peripheral/ButtonLED` flash	%	`examples/Peripheral/ButtonLED` RAM for global variables	%	`examples/Peripheral/CallbackLED` flash	%	`examples/Peripheral/CallbackLED` RAM for global variables	%	`examples/Peripheral/EncryptedBatteryMonitor` flash	%	`examples/Peripheral/EncryptedBatteryMonitor` RAM for global variables	%	`examples/Peripheral/LED` flash	%	`examples/Peripheral/LED` RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0	-36	-0.0	0	0.0
`arduino:megaavr:uno2018:mode=on`	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02	-8	-0.02	1	0.02
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	-40	-0.02	0	0.0	-32	-0.01	0	0.0	-32	-0.01	0	0.0	-32	-0.01	0	0.0	-40	-0.02	0	0.0	-32	-0.01	0	0.0	-40	-0.02	0	0.0	-40	-0.02	0	0.0	-40	-0.02	0	0.0	-40	-0.02	0	0.0	-32	-0.01	0	0.0	-32	-0.01	0	0.0
`arduino:samd:nano_33_iot`	-40	-0.02	0	0.0	-32	-0.01	0	0.0	-32	-0.01	0	0.0	-32	-0.01	0	0.0	-40	-0.02	0	0.0	-32	-0.01	0	0.0	-40	-0.02	0	0.0	-40	-0.02	0	0.0	-40	-0.02	0	0.0	-40	-0.02	0	0.0	-32	-0.01	0	0.0	-32	-0.01	0	0.0

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:mbed_nano:nanorp2040connect,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0,-36,-0.0,0,0.0arduino:megaavr:uno2018:mode=on,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02,-8,-0.02,1,0.02arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:samd:mkrwifi1010,-40,-0.02,0,0.0,-32,-0.01,0,0.0,-32,-0.01,0,0.0,-32,-0.01,0,0.0,-40,-0.02,0,0.0,-32,-0.01,0,0.0,-40,-0.02,0,0.0,-40,-0.02,0,0.0,-40,-0.02,0,0.0,-40,-0.02,0,0.0,-32,-0.01,0,0.0,-32,-0.01,0,0.0arduino:samd:nano_33_iot,-40,-0.02,0,0.0,-32,-0.01,0,0.0,-32,-0.01,0,0.0,-32,-0.01,0,0.0,-40,-0.02,0,0.0,-32,-0.01,0,0.0,-40,-0.02,0,0.0,-40,-0.02,0,0.0,-40,-0.02,0,0.0,-40,-0.02,0,0.0,-32,-0.01,0,0.0,-32,-0.01,0,0.0