- Notifications
You must be signed in to change notification settings - Fork231
Changing BLE HCI transport to spi for Nina based devices#380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
andreagilardoni wants to merge7 commits intoarduino-libraries:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Changing BLE HCI transport to spi for Nina based devices#380
andreagilardoni wants to merge7 commits intoarduino-libraries:masterfromandreagilardoni:ble-vhci-over-spi
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Memory usage change @e9febff
Click for full report table
Click for full report CSV |
nina based devices will be supported through nina spi transportchanging the macro from exclusion to explicit inclusion
Since automatically excluded from previous exclusion preprocessor if
Since in the next version for BLE we are delivering HCI commands throughspi we don't need to restart the nina device for ble to run, thusremoving those commands from this library
e9febff to1fff39aCompare1fff39a to2d56544CompareMemory usage change @2d56544
Click for full report table
Click for full report CSV |
973ca70 toa96f2abCompare87898dd to999e9d7CompareContributorAuthor
andreagilardoni commentedJan 16, 2025
CI now is failing because it requires the release of WiFiNina library |
Memory usage change @999e9d7
Click for full report table
Click for full report CSV |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature depends on the following PRarduino/nina-fw#99, introducing breaking changes in ArduinoBLE library