NotificationsYou must be signed in to change notification settings
Fork231
Star344

Reset scan filters when stopScan is called [Fixes #350]#351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

andrewchilds wants to merge1 commit intoarduino-libraries:master

base:master

Choose a base branch

fromandrewchilds:stopscan-bugfix

Open

Reset scan filters when stopScan is called [Fixes #350]#351

andrewchilds wants to merge1 commit intoarduino-libraries:masterfromandrewchilds:stopscan-bugfix

Conversation

Copy link

andrewchilds commentedFeb 5, 2024

This PR addresses a bug outlined in#350, where callingstopScan does not reset the filters set byscanByName etc, so a call toscan after will not work as expected.

Here's a barebones sketch that demonstrates the bug:

#include<ArduinoBLE.h>#defineSERVICE_UUID"MY-SERVICE-UUID"unsignedlong scanStart;bool fallbackToFullScan =false;voidsetup() {  Serial.begin(9600);delay(1000);// Wait for serialif (!BLE.begin()) {    Serial.println("Starting BLE failed!");while (1);  }  Serial.println("Scanning by Service UUID...");  BLE.scanForUuid(SERVICE_UUID);  scanStart =millis();}voidnotWorkingScan() {  BLE.stopScan();delay(1000);// This scan will not work - it will continue to behave like BLE.scanForUuid(SERVICE_UUID)  BLE.scan();}voidworkingScan() {// This will reset _scanNameFilter, _scanUuidFilter, and _scanAddressFilter to ""  BLE.scanForUuid("");  BLE.stopScan();delay(1000);// This scan will now work  BLE.scan();}voidloop() {  BLEDevice peripheral = BLE.available();if (peripheral) {    Serial.println("Peripheral found!");    BLE.stopScan();  }// Wait 5 seconds to connect, then fall back to a regular scan.if (!fallbackToFullScan &&millis() - scanStart >5000) {    scanStart =millis();    Serial.println("Falling back to full scan...");    fallbackToFullScan =true;// notWorkingScan();workingScan();  }}