Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix for issue #245 - ATT_OP_FIND_INFO_RESP incorrect processing durin…#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
carterd wants to merge1 commit intoarduino-libraries:master
base:master
Choose a base branch
Loading
fromcarterd:master

Conversation

@carterd
Copy link

Fix for issue#245 - ATT_OP_FIND_INFO_RESP incorrect processing during ATTClass::discoverDescriptors causes crashing

I've highlighted this issue on 9th July ... this is an issue of causingCRASHES if using ArduinoBLE to connect as central and the response to ATT_OP_FIND_INFO_RESP includes 128-bit UUIDs.

Please check and remove comments after review

@CLAassistant
Copy link

CLAassistant commentedSep 25, 2022•
edited
Loading

CLA assistant check
All committers have signed the CLA.

… processing during ATTClass::discoverDescriptors causes crashingI've highlighted this issue on 9th July ... this is an issue of causing __CRASHES__ if using ArduinoBLE to connect as central and the response to ATT_OP_FIND_INFO_RESP includes 128-bit UUIDs.
@per1234per1234 added type: imperfectionPerceived defect in any part of project topic: codeRelated to content of the project itself labelsSep 25, 2022
@facchinm
Copy link
Contributor

Hi@carterd ,
thanks for looking into this! I think the PR can be simplified a bit, I'm adding some inline comments. Will be more than happy to merge afterwards 😉

Copy link
Author

@carterdcarterd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Jeez missed this ... looks fine

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@facchinmfacchinmfacchinm requested changes

Assignees

No one assigned

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carterd@CLAassistant@facchinm@per1234
[8]ページ先頭
©2009-2025 Movatter.jp