- Notifications
You must be signed in to change notification settings - Fork220
Overload writeValue to allow forced write without response#146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@bitbank2 I opened this to trigger the CI; would you mind testing it in your environment before we merge it? Thanks |
3e2915a
to62f276c
Comparebitbank2 commentedNov 30, 2020
I'll give it a try today. Thanks :) |
bitbank2 commentedDec 1, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have two 2 tests for the BLE speed. One connects to a BLE thermal printer and prints some graphics and the other uses my VirtualDisplay and sends SSD1306 gfx data over the BLE connection. The Thermal printer test shows that your fix works, but the VirtualDisplay doesn't show any speed improvement. The ESP32 is able to send data 5x faster than the Nano33 under the same conditions. I don't understand why the data transmission on the Nano33 is so much slower even when writeWithoutResponse is used. The last comment I have is that the option to write without response should probably be added to all of the various writeValue() methods too. |
Hi@bitbank2 , so this patch is working and it causes the same effects of#72. I guess that the speed problems also exist with your other solution, am I correct?
|
bitbank2 commentedDec 4, 2020
Please merge and close this PR. |
When a characteristic is declared (Write | WriteWithoutResponse) the code always creates a requestand expects a response.By setting withResponse=false the user can bypass the request and write a responseless command.Reworks and supersedesarduino-libraries#72
c8e0ea6
to8a167ad
Compare
When a characteristic is declared (Write | WriteWithoutResponse) the code always creates a request
and expects a response.
By setting withResponse=false the user can bypass the request and write a responseless command.
Reworks and supersedes#72