Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bump Node version to 20#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@lenvm
Copy link
Contributor

What

This PR updates the actions using Node 16 to Node 20

Why

GitHub is deprecating Node 16 for GitHub Actions. Therefore currently workflow runs using this action show the warningNode.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-arduino-cli@v1. This PR implements that change.

More information is found onGitHub Actions: Transitioning from Node 16 to Node 20

LArkema, stefan-b-jakobsson, SRGDamia1, and stumbaumr reacted with thumbs up emoji
@CLAassistant
Copy link

CLAassistant commentedFeb 6, 2024•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234per1234 added topic: infrastructureRelated to project infrastructure type: imperfectionPerceived defect in any part of project labelsFeb 7, 2024
@LArkema
Copy link

+1 to prioritizing this PR

stumbaumr reacted with thumbs up emoji

@stefan-b-jakobsson
Copy link

I hope this can be merged, as GitHub has announced that it will stop supporting Node16 "by Spring 2024".

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@LArkema
Copy link

@per1234 from what I can tell it looks like you're the main maintainer of this project. Any chance this can be merged?

@lenvm
Copy link
ContributorAuthor

@latchdevel, please sign the CLA such that this PR can be merged.

latchdevel reacted with thumbs up emoji

@latchdevel
Copy link
Contributor

Hi@per1234,

This pull request is ready for review and merging.

Best regards.
Jorge.

@latchdevel
Copy link
Contributor

Looking for PR reviewers:@MatteoPologruto,@LArkema,@stefan-b-jakobsson,@per1234...

stumbaumr reacted with thumbs up emoji

Copy link
Contributor

@latchdevellatchdevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is not entirely orthodox to review the changes myself, but there seems to be a lack of will, and the truth is that they are quite simple.

@latchdevel
Copy link
Contributor

Looking for PR reviewers:@umbynos ,@alessio-perugini ,@cmaglie ....

@alessio-perugini
Copy link
Contributor

@latchdevel thank you for the ping. Sorry for the late response, I will prepare a followup PR to address some changes made in arduino-cli tagging convention, so this action will be able to pickup new v1.y.z versions.

latchdevel and pfeerick reacted with thumbs up emoji

@alessio-peruginialessio-perugini merged commit8dc9514 intoarduino:masterJul 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@alessio-peruginialessio-peruginialessio-perugini approved these changes

@latchdevellatchdevellatchdevel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: infrastructureRelated to project infrastructuretype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lenvm@CLAassistant@LArkema@stefan-b-jakobsson@latchdevel@alessio-perugini@per1234
[8]ページ先頭
©2009-2025 Movatter.jp