Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove version field from package.json#56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@MatteoPologruto
Copy link
Contributor

Theversion field is only needed if the package is to be published. In this project,package.json is used only for management of the dependencies and scripts for internal development.

For this reason, having aversion field in the file is harmful because it increases the effort and complexity of making a release, and also is likely to get out of sync with the true version.

Reference:

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#version

If you don't plan to publish your package, the name and version fields are optional.


This was done last year for thearduino/setup-task action without any ill effects:arduino/setup-task#49.
The same was done for thearduino/arduino-lint-action action:arduino/arduino-lint-action#69

@MatteoPologrutoMatteoPologruto added type: enhancementProposed improvement topic: infrastructureRelated to project infrastructure labelsMay 15, 2023
@MatteoPologrutoMatteoPologruto self-assigned thisMay 15, 2023
@MatteoPologrutoMatteoPologruto merged commit0252d5c intoarduino:masterMay 16, 2023
@MatteoPologrutoMatteoPologruto deleted the remove-version-field branchMay 16, 2023 10:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@per1234per1234Awaiting requested review from per1234

1 more reviewer

@umbynosumbynosumbynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MatteoPologrutoMatteoPologruto

Labels

topic: infrastructureRelated to project infrastructuretype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatteoPologruto@umbynos

[8]ページ先頭

©2009-2025 Movatter.jp