Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork10
update to node16 (node12 support deprecated)#48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Seehttps://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.Every user of this action is now getting warnings (not yet errors).**_IMPORTANT_** - this change hasn't been tested. this is because I'm not sure how I would do so. given the trivial nature, it's likely the repo's built-in self-tests should give a pass/fail....
CLAassistant commentedOct 21, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
per1234 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@henrygab. The project infrastructure also must be updated to use Node.js 16.x in order to allow development and validation using the same version as will be used on the GitHub Actions runner:
- Update
package-lock.jsonfile to the lockfileVersion 2 data format used by Node.js 16.x - Update the unit test workflow to run the tests using Node.js 16.x (it is currently using 10.x 👴)
henrygab commentedOct 21, 2022
I updated the test runner to install Node 16.x instead of Node 10.x. I realize that validation is still necessary, and I am not familiar enough to attempt the lockfile changes. (while I love learning, time is a limiting factor.) Thank you for self-assigning! |
astraw commentedDec 16, 2022
I am getting this warning, too.@per1234 are there any remaining issues? AFAICS the changed requested have now been made. It would be great to make a release with to address the warning. |
lhstrh commentedFeb 15, 2023
Is there anything left to do before this can get merged and released? It would be great to get rid of the warnings... |
ChanceCuddeback commentedApr 24, 2023
What is the status on this. I am a beginner at Github Actions so it may be my fault, but the action is now broken? Do I have to used a differenct verison of the action? |
joshua-8 commentedApr 24, 2023
@ChanceCuddeback This action is still working for mehere, though there are warnings that the action will stop working soon, so I hope it is fixed soon. Thank you Arduino Team for all your work. |
per1234 commentedOct 3, 2023
Closing as superseded by#54 |
Seehttps://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Every user of this action is now getting warnings (not yet errors). For example:
I have verified this small change removes this warning when I point to this PR branch. Given the simplicity of the fix, I hope that's sufficient.