Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9
Remove version field frompackage.json#69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The `version` field is only needed if the package is to be published. In this project, package.json is only used formanage dependencies and scripts for internal development.For this reason, having a `version` field is harmful because it increases the effort and complexity of making a release,and also is likely to get out of sync with the true version.
umbynos approved these changesMar 21, 2022
This was referencedMay 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
versionfield is only needed if the package is to be published. In this project,package.jsonis used only for management of the dependencies and scripts for internal development.For this reason, having a
versionfield in the file is harmful because it increases the effort and complexity of making a release, and also is likely to get out of sync with the true version.Reference:
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#version
This was done last year for the
arduino/setup-taskaction without any ill effects:arduino/setup-task#49