Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9
Specify Node.js 16.x runtime for action execution in runner#193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The Node.js version for use when executing the action in the GitHub Actions runner is configured via the `runs.using`field of the `action.yml` metadata file.Previously, the action was configured to use Node.js 12.x. This was actually the result of an oversight, as Node.js 16.xhas been used for the development and validation of the action since 2022-01-10. It will be important to use the sameversion on the runner as the action is validated for by the project infrastructure in order to ensure the expectedbehavior.In addition, GitHub has deprecated the use of Node.js 12.x runtime. A warning about this was shown in the workflow runsummary page of all workflows using this action. That warning will be resolved, and the eventual complete breakage ofthose workflows avoided, by this change.
MatteoPologruto approved these changesOct 27, 2022
MatteoPologruto left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks Per!
RobTillaart commentedOct 27, 2022
Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: infrastructureRelated to project infrastructure type: imperfectionPerceived defect in any part of project
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node.js version for use when executing the action in the GitHub Actions runner is configured via the
runs.usingfield of theaction.ymlmetadata file.Previously, the action was configured to useNode.js 12.x. This was actually the result of an oversight, asNode.js 16.x has been used for the development and validation of the action since 2022-01-11 (#42). It will be important to use the same version on the runner as the action is validated for by the project infrastructure in order to ensure the expected behavior.
In addition,GitHub has deprecated the use of Node.js 12.x runtime. A warning about this was shown in the workflow run summary page of all workflows using this action (#182). That warning will be resolved, and the eventual complete breakage of those workflows avoided, by this change.
Fixes#182