Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Manage versioning of Task tool dependency#962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
per1234 merged 2 commits intoarduino:mainfromper1234:go-modules-task
Sep 15, 2025

Conversation

@per1234
Copy link
Contributor

@per1234per1234 commentedSep 15, 2025
edited
Loading

The "Task" task runner tool is used to perform all common development and maintenance operations for the project.

Previously, the version of Task was not well managed.

The GitHub Actions workflows used the latest version of Task, only constrained by major version. This meant that the GitHub Actions workflows could break at any time through a new release of Task that contained regressions or breaking changes.

The contributors used whichever version of Task happened to be installed on their machine. This meant that they might get different results from that produced by the environment of the GitHub Actions workflows.

The better solution is to take the same approach for managing the Task dependency as is done for the project's other dependencies:

  • Install a specific version of Task according to a single source of versioning data.
  • Use the Dependabot service to get automated update pull requests.

Since Task is a Go module-based project, this can be accomplished by using the Go modules system, which hasexplicit support for tool dependencies as of the Go 1.24 release. The "yq" tool dependency is managed via the Go modules system. It must be invoked viago tool in order for the managed
version to be used.

@per1234per1234 self-assigned thisSep 15, 2025
@per1234per1234 added type: enhancementProposed improvement topic: infrastructureRelated to project infrastructure labelsSep 15, 2025
@per1234per1234 changed the titleInvoke yq via go toolManage versioning of Task tool dependencySep 15, 2025
@codecov
Copy link

codecovbot commentedSep 15, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (ec8d60c) to head (fa98bca).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main     #962   +/-   ##=======================================  Coverage   83.33%   83.33%           =======================================  Files           1        1             Lines         180      180           =======================================  Hits          150      150             Misses         19       19             Partials       11       11
FlagCoverage Δ
unit83.33% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The "yq" tool dependency is managed via the Go modules system. It must be invoked via `go tool` in order for the managedversion to be used.
The "Task" task runner tool is used to perform all common development and maintenance operations for the project.Previously, the version of Task was not well managed.The GitHub Actions workflows used the latest version of Task, only constrained by major version. This meant that theGitHub Actions workflows could break at any time through a new release of Task that contained regressions or breakingchanges.The contributors used whichever version of Task happened to be installed on their machine. This meant that they mightget different results from that produced by the environment of the GitHub Actions workflows.The better solution is to take the same approach for managing the Task dependency as is done for the project's otherdependencies:* Install a specific version of Task according to a single source of versioning data.* Use the Dependabot service to get automated update pull requests.Since Task is a Go module-based project, this can be accomplished by using the Go modules system, which has explicitsupport for tool dependencies as of the Go 1.24 release.
@per1234per1234 merged commitc142981 intoarduino:mainSep 15, 2025
71 of 74 checks passed
@per1234per1234 deleted the go-modules-task branchSeptember 15, 2025 18:15
@per1234
Copy link
ContributorAuthor

Use the Dependabot service to get automated update pull requests.

I discovered that I was mistaken about this effect. AlthoughDependabot does provide update PRs when tool dependencies are managed viathe alternative provisional "tools.go" approach, unfortunately it does not for tools managed via the newertools directive:dependabot/dependabot-core#12050

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@per1234per1234

Labels

topic: infrastructureRelated to project infrastructuretype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@per1234

[8]ページ先頭

©2009-2025 Movatter.jp