This brings the Arduino CLI integration up to 0.35.x branch (the latest before the big 1.0 break).
I've taken the chance to upgrade golang to 0.22.5 (we are still not supporting 0.23.0 in the Disttask.yml file).

Copy link

codecovbot commentedOct 1, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base(cf59441) to head(0c7f6cf).
Report is 23 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main     #761      +/-   ##==========================================- Coverage   90.05%   89.97%   -0.09%==========================================  Files          44       44                Lines        6800     6772      -28     ==========================================- Hits         6124     6093      -31- Misses        553      555       +2- Partials      123      124       +1

Flag	Coverage Δ
unit	`89.97% <ø> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

cmaglie self-assigned this

Oct 1, 2024

cmaglie added type: enhancement

Proposed improvement

dependencies labels

Oct 1, 2024

cmaglie force-pushed theupdate-extract-lib branch 4 times, most recently fromde93d49 to48471b7Compare

October 2, 2024 14:07

per1234 added topic: infrastructureRelated to project infrastructure and removed dependencies labels

Oct 8, 2024

per1234 mentioned this pull request

Oct 16, 2024

Use golangci-lint instead of golint#778

Open

cmaglie force-pushed theupdate-extract-lib branch from48471b7 to07ead9bCompare

October 16, 2024 15:00

Copy link

Contributor

per1234 commentedOct 16, 2024•
edited
Loading

I apologize for introducing merge conflicts for this PR in the workflows@cmaglie. I have a couple more changes to make in the workflows to get them fully up to date and I'll take care of rebasing the PR once those are done. I'm not touching any Go code or dependencies or integration tests.

cmaglie added6 commits

October 16, 2024 17:26

Updated arduino-cli to 0.35.x branch

2313c6c

Update supported go version to 1.22.5

c4e16c9

Fixed 'stringer' by upgrading a lot of go-lang internal libraries

0906bcc

Fixed unit test

6b90fcf

Removed checks on sketch.json (now deprecated)

1fc2dfb

Fixed panic in some library ruleset

0afb39d

cmaglie force-pushed theupdate-extract-lib branch frome736753 to6c3cabaCompare

October 16, 2024 15:28

Copy link

MemberAuthor

cmaglie commentedOct 16, 2024

I apologize for introducing merge conflicts for this PR in the workflows@cmaglie.

No worries, I've already rebased it, the changes were trivial.

Removed tests and rules about sketch.json (now deprecated)

068d4ce

cmaglie force-pushed theupdate-extract-lib branch from6c3caba to068d4ceCompare

October 16, 2024 15:35

Silence linter warning

0e6248f

Copy link

MemberAuthor

cmaglie commentedOct 16, 2024

@per1234 I removed the checks forsketch.json from the ruleset since it's now deprecated in favor ofsketch.yaml, that's the reason for the small reduction in the test coverage.

I want to add checks for thesketch.yaml, but IMHO this should be done after we merge the support for the CLI 1.0+.

cmaglie requested review fromMatteoPologruto,alessio-perugini,per1234 andumbynos

October 16, 2024 15:49

alessio-perugini approved these changes

Oct 16, 2024

View reviewed changes

Copy link

Contributor

alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

per1234 previously requested changes

Oct 16, 2024

View reviewed changes

Copy link

Contributor

per1234 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This needs to be updated:

arduino-lint/Taskfile.yml

Line 326 in0e6248f

GO_VERSION:1.17

The reason I did this is because I found that, without it, the project had a lot of unused transitive dependencies (for example, when I updated a direct module dependency and did ago mod tidy, a former dependency of that direct dependency that was no longer used by the new version would be left behind in the go.mod+go.sum, and thus in the license metadata, even though it was no longer used by anything). Once I added the-compat=1.17 flag,go tidy behaved exactly as I expected. Apparently the unexpected behavior was due to Go needing to do a suboptimal tidy in order to provide compatibility with certain other versions of Go, but we don't support the use of the project with versions of Go other than the one specified by thego directive so that isn't of interest.

I don't know whether the-compat flag is needed for proper tidy behavior with 1.22 though.

This needs to be updated:

arduino-lint/docs/CONTRIBUTING.md

Line 79 in0e6248f

-[Go](https://golang.org/doc/install) version 1.17 or later

Or we can merge#801 now and render it obsolete:

arduino-lint/docs/CONTRIBUTING.md

Lines 79 to 81 inbe9eff0

	-[Go](https://golang.org/doc/install
	- TheGo version in use is defined in the`go` directive of
	[`go.mod`](https://github.com/arduino/arduino-lint/blob/main/go.mod).

go.mod OutdatedShow resolvedHide resolved

umbynos approved these changes

Oct 17, 2024

View reviewed changes

cmaglie added2 commits

October 18, 2024 12:45

Updated CONTRIBUTING.md

7081697

Removed toolchain directive from go.mod

0c7f6cf

cmaglie force-pushed theupdate-extract-lib branch froma177ea3 to0c7f6cfCompare

October 18, 2024 10:57

Copy link

MemberAuthor

cmaglie commentedOct 18, 2024•
edited
Loading

Or we can merge#801 now and render it obsolete:
arduino-lint/docs/CONTRIBUTING.md
Lines 79 to 81 inbe9eff0
-[Go](https://golang.org/doc/install
- The**Go** version in use is defined in the`go` directive of
[`go.mod`](https://github.com/arduino/arduino-lint/blob/main/go.mod).

With the latestgo versions, the compiler should automatically set compatibility mode with the toolchain version specified in thego.mod file, so it should be enough to download a version of the toolchain that is >= of the required version. This differs from older releases, where you had to download the exact version ofgo used for the build. At least, this is my experience. Maybe we can try to build this project with go 1.23 to confirm it.