Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork468
fix: wait for theiainitalWindow
to be set before opening sketch throughopen-file
event#2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
23582d8
to0a6ce3e
Compareopen-file
event after initial window is showninitalWindow
to be set before opening sketch throughopen-file
eventdavegarthsimpson approved these changesApr 7, 2025
a669a43
intomain 44 checks passed
Uh oh!
There was an error while loading.Please reload this page.
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Motivation
Resolves#2688
Change description
Theia internally create an initial empty window on app start to improve UX while first loading the app instance, seeeclipse-theia/theia#12897
On MacOS, since open sketch via file association was triggered before initial window reference was set, the open sketch logic would create a new window instance instead of reusing the early created window reference, leaving an unresponsive additional empty window.
Currently there is no ideal way to wait or react to
initialWindow
value change, so we pool on the value.Note that this only needed on the first window startup as on other instances,
showWindowEarly
is not used andinitialWindow
is null.The pool sets a generous amount of retries but should bail consistently on the first try as
initialWindow
is set right after the app is ready. Note that in case the pools times out, we open the sketch on a new window anyway.