Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: wait for theiainitalWindow to be set before opening sketch throughopen-file event#2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
davegarthsimpson merged 2 commits intomainfromfix-macos-empty-window
Apr 7, 2025

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinatogiacomocusinato commentedApr 7, 2025
edited
Loading

Motivation

Resolves#2688

Change description

Theia internally create an initial empty window on app start to improve UX while first loading the app instance, seeeclipse-theia/theia#12897
On MacOS, since open sketch via file association was triggered before initial window reference was set, the open sketch logic would create a new window instance instead of reusing the early created window reference, leaving an unresponsive additional empty window.

Currently there is no ideal way to wait or react toinitialWindow value change, so we pool on the value.
Note that this only needed on the first window startup as on other instances,showWindowEarly is not used andinitialWindow is null.
The pool sets a generous amount of retries but should bail consistently on the first try asinitialWindow is set right after the app is ready. Note that in case the pools times out, we open the sketch on a new window anyway.

@giacomocusinatogiacomocusinato added topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project labelsApr 7, 2025
@giacomocusinatogiacomocusinato marked this pull request as draftApril 7, 2025 09:34
@giacomocusinatogiacomocusinato self-assigned thisApr 7, 2025
@giacomocusinatogiacomocusinato marked this pull request as ready for reviewApril 7, 2025 16:15
@giacomocusinatogiacomocusinato changed the titlefix: subscribe toopen-file event after initial window is shownfix: wait for theiainitalWindow to be set before opening sketch throughopen-file eventApr 7, 2025
@davegarthsimpsondavegarthsimpson merged commita669a43 intomainApr 7, 2025
44 checks passed
@davegarthsimpsondavegarthsimpson deleted the fix-macos-empty-window branchApril 7, 2025 17:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@davegarthsimpsondavegarthsimpsondavegarthsimpson approved these changes

Assignees

@giacomocusinatogiacomocusinato

Labels
topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra blank window when IDE started via sketch file association
2 participants
@giacomocusinato@davegarthsimpson

[8]ページ先頭

©2009-2025 Movatter.jp