Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork470
fix: preventOutputWidget to gain focus when updated#2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
davegarthsimpson approved these changesApr 3, 2025
e36f393 intomain 36 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: codeRelated to content of the project itself topic: theiaRelated to the Theia IDE framework type: imperfectionPerceived defect in any part of project
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves#2679
Change description
Prevent
ApplicationShellto set main window focus if revealed widget isOutputWidgetOther information
Although I wasn't able to reproduce the issue in Theia IDE Desktop v1.57.0, seems that the problem might be caused by a regression or an expected change in behaviour in Theia. To deal with the secondary window, Theia might prioritize the main one when
OutputWidgetis refreshed (seeeclipse-theia/theia#13493)An issue will follow on Theia side after a deeper analysis or anything new is found.