Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ATL-1136: Add .adoc and .md file support#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fstasi merged 1 commit intomainfromatl-1136--documentation-file-extensions
Mar 29, 2021

Conversation

@fstasi
Copy link
Contributor

@fstasifstasi commentedMar 24, 2021•
edited
Loading

This PR add support to create and view.md and.adoc files in IDE2. It also fix .S file extension (see#218 )

Note: this PR alone do not solve the fact the IDE2 do not open automatically .md and .adoc files belonging to a sketch. That will be handled in a separate PR addressingATL-1152

How to test

  • open IDE2
  • create a new tab using the top right button
  • give it a name and and extension.md or.adoc

Demo

doc-file-support

Tasks

ATL-1136
fixes#218

@fstasifstasi requested a review fromkittaakosMarch 24, 2021 10:56
@kittaakos
Copy link
Contributor

The CLI does not yet support these files, there is not much to review here.

@kittaakos
Copy link
Contributor

Could you please cover#218 in this PR?

fstasi reacted with thumbs up emoji

@fstasifstasiforce-pushed theatl-1136--documentation-file-extensions branch fromc19d23b tod9afedeCompareMarch 25, 2021 11:29
@fstasifstasi linked an issueMar 25, 2021 that may beclosed by this pull request
Copy link

@ubidefeoubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have tested also against#218
LGTM

@fstasifstasi merged commitb17b7a6 intomainMar 29, 2021
@kittaakoskittaakos deleted the atl-1136--documentation-file-extensions branchApril 8, 2021 12:42
@per1234per1234 added topic: codeRelated to content of the project itself type: enhancementProposed improvement labelsOct 25, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ubidefeoubidefeoubidefeo approved these changes

+1 more reviewer

@kittaakoskittaakoskittaakos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: codeRelated to content of the project itselftype: enhancementProposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assembly language file extension has the wrong case

4 participants

@fstasi@kittaakos@ubidefeo@per1234
[8]ページ先頭
©2009-2025 Movatter.jp