NotificationsYou must be signed in to change notification settings
Fork516
Star2.9k

fix: nested cloud sketch folder sync#2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

kittaakos wants to merge4 commits intomain

base:main

Choose a base branch

fromfix-nested-sketch-cloud-sync

Draft

fix: nested cloud sketch folder sync#2388

kittaakos wants to merge4 commits intomainfromfix-nested-sketch-cloud-sync

Conversation

Copy link

Contributor

kittaakos commentedFeb 23, 2024

Motivation

This is a work-in-progress IDE2 activity for supporting custom libraries inside nested folders of the sketch folder:arduino/arduino-cli#2514

Change description

fix remap Create API 404 error to VS CodeFileSystem-specific error,
order resource creation to ensure the container folder of nested resources already exists,
initial support of creating folders from theSketchbook view

Other information

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among thePull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

Akos Kitta added3 commits

February 23, 2024 08:51

fix: nested cloud sketch folder sync

478c36c

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

fix: order the resources to delete

67e863d

longest path comes first to remove to most nested resources, then theircontainer if any.Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

feat: can create new folder

fb3c0ca

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

kittaakos added type: enhancement

Proposed improvement

topic: code

Related to content of the project itself

type: imperfection

Perceived defect in any part of project

topic: cloudRelated to Arduino Cloud and cloud sketches labels

Feb 23, 2024

fix(i18n): regenerate translation file

fab2f93

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

Copy link

CLAassistant commentedApr 1, 2024

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.

Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}