NotificationsYou must be signed in to change notification settings
Fork460
Star2.7k

fix: let the upload run when no board is selected#2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

kittaakos wants to merge1 commit intomain

base:main

Choose a base branch

from#1714

Open

fix: let the upload run when no board is selected#2387

kittaakos wants to merge1 commit intomainfrom#1714

Conversation

Copy link

Contributor

kittaakos commentedFeb 23, 2024

Motivation

IDE2 must not disable the upload from the UI when no board is selected. Otherwise, IDE2 does not receive theno FQBN error from the CLI and cannot suggest selecting a board via theTools >Board menu.

Change description

Other information

Closes#1714

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among thePull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

fix: let the upload run when no board is selected

3c5c014

IDE2 must not disable the upload from the UI when no board is selected.Otherwise, IDE2 does not receive the `no FQBN` error fromthe CLI and cannot cannotsuggest selecting a board via the `Tools` > `Board` menu.Closes#1714Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

kittaakos added topic: code

Related to content of the project itself

type: imperfectionPerceived defect in any part of project labels

Feb 23, 2024

kittaakos requested review fromgiacomocusinato anddavegarthsimpson

February 23, 2024 14:39

giacomocusinato approved these changes

Feb 23, 2024

View reviewed changes

Copy link

CLAassistant commentedApr 1, 2024

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.

Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}