Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork470
fix: falsy context menuhandlerId#2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The very first context menu item with ID `0` has not had a click handlerRef:eclipse-theia/theia#12500Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
per1234 approved these changesAug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I verified this fixesforum#1160085.
Thanks Akos!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: codeRelated to content of the project itself topic: theiaRelated to the Theia IDE framework type: imperfectionPerceived defect in any part of project
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To fix the non-functional
New Tabcontent menu item from•••. The first context menu item with ID0has no click handler.Change description
Customized the default Theia menu item building to attach the click handler to the menu node with ID
0Steps to reproduce:
File>New Sketch, orCtrl/Cmd+N),•••,New Tabthe new file dialog opens.Other information
Originally reported here:https://forum.arduino.cc/t/new-tab-command-first-invocation-does-nothing/1160085
Ref:eclipse-theia/theia#12500 (comment)
Reviewer checklist