Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork515
fix: restorewindow.titleBarStyle andbreadcrumbs.enabled#1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
kittaakos wants to merge2 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 tasks
window.titleBarStylewindow.titleBarStyle andbreadcrumbs.enabled3 tasks
CLAassistant commentedApr 1, 2024
Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let usrecheck it. |
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: codeRelated to content of the project itself topic: theiaRelated to the Theia IDE framework type: imperfectionPerceived defect in any part of project
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Motivation
This PR partiallyfixes#1733 and#2716 by restoring the default Theia behavior of the
window.titleBarStyle(on Windows and Linux) andbreadcrumbs.enabledpreferences.Change description
breadcrumbs.enabledshould enable the breadcrumbs on all platforms. By default, it is disabled in IDE2.The
window.titleBarStylepreference should be verified together with thewindow.menuBarVisibilityvalues. The custom menu has special handling from Theia when the app is running in full-screen mode:Other information
Ref:#1733 and#2716
Reviewer checklist