NotificationsYou must be signed in to change notification settings
Fork515
Star2.8k

feat: icon for cloud sketch in File > Open Recent#1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

kittaakos wants to merge2 commits intomain

base:main

Choose a base branch

from#1826

Draft

feat: icon for cloud sketch in File > Open Recent#1868

kittaakos wants to merge2 commits intomainfrom#1826

Conversation

Copy link

Contributor

kittaakos commentedFeb 8, 2023•
edited
Loading

Depends on#1833

Motivation

As asked for in#1826, IDE2 would like to show an icon for cloud sketches in File > Open Recent.

This is just the infrastructure and an example of how IDE2 can render a custom image for a menu item. The images are missing from the PR.Here is the documentation of supported native image formats. If IDE2 wants to dispatch images on the selected theme, I am happy to update the PR.

Source of my example cloud image:https://imagensemoldes.com.br/wp-content/uploads/2020/04/%C3%8Dcone-Computador-Nuvem-PNG.png

Change description

Dedicated static folder on the IDE2 backed to host the images,
Exposed endpoint from IDE2 backend to load the image as a binary,
IDE2 frontend fetches the image content and builds anativeImage.
A cloud icon is rendered in the native menu item if the sketch is insidedirectories.data/RemoteSketchbook.

Other information

Ref:#1826

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among thePull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

kittaakos requested review from91volt andAlbyIanna

February 8, 2023 13:47

per1234 added type: enhancement

Proposed improvement

topic: codeRelated to content of the project itself labels

Feb 9, 2023

kittaakos force-pushed the#1826 branch from42f6237 to65add68Compare

February 9, 2023 10:08

This was referencedFeb 9, 2023

fix: restorewindow.titleBarStyle andbreadcrumbs.enabled#1870

Draft

Change name and iconography: Remote -> Cloud#1826

Open

kittaakos force-pushed the#1825 branch 2 times, most recently from048f452 toadf3dcfCompare

February 13, 2023 15:49

kittaakos self-assigned this

Feb 15, 2023

Base automatically changed from#1825 tomain

February 15, 2023 13:09

kittaakos marked this pull request as draft

February 23, 2023 09:31

Copy link

Collaborator

davegarthsimpson commentedMar 24, 2023

@kittaakos is this pending a design decision? Thanks

If IDE2 wants to dispatch images on the selected theme

Copy link

ContributorAuthor

kittaakos commentedMar 24, 2023

@kittaakos is this pending a design decision? Thanks

@davegarthsimpson, yes.

Copy link

91volt commentedMar 24, 2023

@kittaakos the icon looks great.
-> if is possible to make the icons theme dependent would be great. Tell me if you need assets for that.
-> If is not feasible to have it in time for our next release, for now we can adopt the same solution of the titlebar, with "Cloud" textual prefix.

wdyt?

Copy link

ContributorAuthor

kittaakos commentedMar 24, 2023

-> if is possible to make the icons theme dependent would be great. Tell me if you need assets for that.

Yes, IDE2 needs the icons if the feature is required. Please see the PR description with the electron restrictions on the icon.

-> If is not feasible to have it in time for our next release,

I am not in the loop, I do not even know when does the next release happen.

Akos Kitta added2 commits

March 27, 2023 17:24

feat: icon for cloud sketch in File > Open Recent

2e7f2d9

Ref:#1826Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

feat: new icons + dispatch based on the theme

c8e447c

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

kittaakos force-pushed the#1826 branch from65add68 toc8e447cCompare

March 27, 2023 16:34

Copy link

ContributorAuthor

kittaakos commentedMar 28, 2023

If IDE2 wants to dispatch images on the selected theme

Dispatching the icon based on IDE2's theme is not the best idea. The OS native menu is still dark, although the IDE2's theme is light. Please decide,@91volt. Thanks!

In-action:

cloud_icon_ide_theme.mp4

per1234 added the topic: cloudRelated to Arduino Cloud and cloud sketches label

Apr 13, 2023

Copy link

ContributorAuthor

kittaakos commentedOct 5, 2023

Dispatching the icon based on IDE2's theme is not the best idea.

Another approach could be using thenativeTheme from Electron.

kittaakos removed their assignment

Feb 23, 2024

Copy link

CLAassistant commentedApr 1, 2024

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.

Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}