Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork515
[WIP] Add opened examples to Open Recent menu#1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
francescospissu wants to merge3 commits intomainChoose a base branch fromopen-recent-examples
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
b7f435c to750486aCompare3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when an example sketch is opened it is not added to the
Open Recentmenu.Change description
A temporary sketch can be added to the
Open Recentmenu if it doesn't include the stringsketch_in the name.Other information
Closes#935.
Different solutions have been investigated to solve this problem, including:
Remove the return if a sketch is temporary in the
markAsRecentlyOpenedfunctionarduino-ide/arduino-ide-extension/src/node/sketches-service-impl.ts
Lines 280 to 281 in5cb9166
Solution discarded because in this way also a new sketch created from
File -> Newis added to the recents.Change the
parentPathof the new opened example without the creation of a temporary folder in thecloneExamplefunctionarduino-ide/arduino-ide-extension/src/node/sketches-service-impl.ts
Line 339 in5cb9166
Solution discarded because the example is added directly to the sketchbook without saving it previously.
The current solution is not yet valid because a better way must be found to prevent an example from being considered a "standard" temporary file.
Reviewer checklist