Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork515
Commitfe19e0e
committed
Use Apple Silicon build artifact name required by electron-updater
The Arduino IDE update check uses a "channel update info file" on Arduino's download server. This file specifies thelatest version of Arduino IDE available from the Arduino download server as well as the download URLs for the releasearchives.There is a separate channel file for each host operating system:- Windows- Linux- macOSTwo macOS host architectures are now supported:- x86 (AKA "Intel")- ARM64 (AKA "Apple Silicon")These each have their own release archive files. The macOS channel file contains data on both. So the updater must beable to identify the appropriate archive to use for the update based on the host architecture. This is based on thearchive filename.Arduino IDE's auto-update feature is built on the electron-updater package. The release archive selection is handled bythe electron-updater codebase and the filename pattern is hardcoded there. It selects the archive file that contains`arm64` in its name (case sensitive), if present, to use for updates on macOS hosts with ARM64 architecture.Previously, the build system produced archive files with the name format arduino-ide_<version>_macOS_ARM64.zip,consistent with the established naming in other Arduino tooling projects. Unfortunately this naming would cause either(depending on the order of the entries in the channel file) the x86 build to be used to update ARM64 macOS hosts(resulting in lesser performance due to Rosetta 2 overhead) or the ARM64 build to be used to update x86 hosts (resultingin the IDE failing to start).So it is necessary to change the build artifact name to follow the format dictated by the electron-updater package.Although it is not required (because electron-updater uses separate channel files for the x86 and ARM hosts), the Linuxarchive filename format was also changed for the sake of consistency.1 parentc0af297 commitfe19e0e
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
0 commit comments
Comments
(0)