Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: refactor import paths and add feedback and i18n packages#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dido18 merged 5 commits intomainfromremove-orch-dependencies
Oct 15, 2025

Conversation

@dido18
Copy link
Contributor

@dido18dido18 commentedOct 15, 2025•
edited
Loading

Remove external dependencies by copying/pasting thei18n andfeedback packages here.

Other

  • renamed the module togithub.com/arduino/arduino-flasher-cli
  • updated the license header of the packages with the commandaddlicense -c "ARDUINO SA (http://www.arduino.cc/)" -f ./license_header.tpl $(find . -name "*.go" -type f -print0 | xargs -0)

Other notes

  • Thei18n can be removed. Translation can be added when needed
  • revise the usage of the feedack package, remove not used code

@dido18dido18 requested review froma team andMatteoPologrutoOctober 15, 2025 09:52
@dido18
Copy link
ContributorAuthor

Build tested locally with go build -ldflags "-X main.Version=1.0.0" -v -o .

Copy link
Contributor

@MatteoPologrutoMatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some nitpicks

dido18and others added3 commitsOctober 15, 2025 12:20
Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
@dido18dido18 merged commit8f86284 intomainOct 15, 2025
@dido18dido18 deleted the remove-orch-dependencies branchOctober 15, 2025 10:46
lucarin91 pushed a commit that referenced this pull requestOct 28, 2025
* feat: refactor import paths and add feedback and i18n packages* feat: update copyright and licensing information in source filesCo-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>---------Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MatteoPologrutoMatteoPologrutoMatteoPologruto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dido18@MatteoPologruto
[8]ページ先頭
©2009-2025 Movatter.jp