Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork48
Only delay after serial output in "Knock"#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The "Knock" sketch polls the voltage output from a piezo disc to detect the vibrations associated with a knock.The duration of vibrations from a single knock is likely to significantly exceed the unchecked polling interval. Thiswould result in a single knock producing multiple detections, and thus multiple prints to Serial. In order to avoidthis, a "debouncing" delay was added to the sketch.Previously the delay was positioned in the outer scope of the `loop` function, which caused it to always affect thepolling interval. This caused the sketch to miss the detection of knocks that produced vibrations that only occurredduring that unnecessary delay. The problem is fixed by moving the delay inside the knock detection conditional block, sothat debouncing is only done when actually needed.
00b6086 intoarduino:main 17 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Knock" sketch polls the voltage output from a piezo disc to detect the vibrations associated with a knock.
The duration of vibrations from a single knock is likely to significantly exceed the unchecked polling interval. This would result in a single knock producing multiple detections, and thus multiple prints to
Serial. In order to avoid this, a "debouncing" delay was added to the sketch.Previously the delay was positioned in the outer scope of the
loopfunction, which caused it to always affect the polling interval. This caused the sketch to miss the detection of knocks that produced vibrations that only occurred during that unnecessary delay. The problem is fixed by moving the delay inside the knock detection conditional block, so that debouncing is only done when actually needed.Originally reported atarduino/docs-content#2159