Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Restrict ArduinoISP name collision fix to ArduinoCore-API 1.0.1#24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
facchinm merged 1 commit intoarduino:mainfromper1234:arduinoisp-arduinocore-api-version
Nov 18, 2020
Merged

Restrict ArduinoISP name collision fix to ArduinoCore-API 1.0.1#24

facchinm merged 1 commit intoarduino:mainfromper1234:arduinoisp-arduinocore-api-version
Nov 18, 2020

Conversation

@per1234
Copy link
Contributor

@per1234per1234 commentedNov 18, 2020
edited
Loading

ArduinoCore-API 1.0.1 declares aSPISettings class:
https://github.com/arduino/ArduinoCore-API/blob/7c9e4f8abde3ce75234e51c0e5be3083832c3e49/api/ArduinoAPI.h#L31
but ArduinoCore-API 1.0.0 and 1.1.0 don't do this:

Reference:b94e757#r44269343

facchinm reacted with rocket emoji
ArduinoCore-API 1.0.1 declares a SPISettings class, but ArduinoCore-API 1.0.0 and 1.1.0 don't do this, so the previous preprocessor conditional that was added to fix the ArduinoCore-API sketch for platforms using ArduinoCore-API 1.0.1 actually breaks it for platforms using previous or later versions.
per1234 referenced this pull requestNov 18, 2020
…bitbanged SPI mode for board using ArduinoCore-APIWhen using bit banged SPI, which the sketch did when compiled for any architecture other than AVR, a `SPISettings` class was declared by the sketch. At the time the sketch was written, it was reasonable to expect this would not cause a name collision, since SPI.h is not `#include`d when doing bit banged SPI. However, since then a `SPISettings` class has been declared in [ArduinoCore-API's HardwareSPI.h](https://github.com/arduino/ArduinoCore-API/blob/932c7c7d4d4d334b10484284cc846672ad59607c/api/HardwareSPI.h#L37), causing the ArduinoISP sketch to not compile for any board whose core uses ArduinoCoreAPI (currently Arduino Mega AVR Boards, "Arduino nRF528x Boards (Mbed OS]", and "Arduino Mbed OS Boards (nRF52840 / STM32H747)"):```  /github/workspace/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino:191:27: error: reference to 'SPISettings' is ambiguous       void beginTransaction(SPISettings settings) {                             ^~~~~~~~~~~  /github/workspace/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino:167:7: note: candidates are: class SPISettings   class SPISettings {         ^~~~~~~~~~~  In file included from /github/home/.arduino15/packages/arduino/hardware/megaavr/1.8.6/cores/arduino/api/ArduinoAPI.h:31:0,                   from /github/home/.arduino15/packages/arduino/hardware/megaavr/1.8.6/cores/arduino/Arduino.h:23,                   from /github/workspace/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino:39:  /github/home/.arduino15/packages/arduino/hardware/megaavr/1.8.6/cores/arduino/api/HardwareSPI.h:37:7: note:                 class arduino::SPISettings   class SPISettings {         ^~~~~~~~~~~```The fix is to use the `ARDUINO_API_VERSION` macro defined by ArduinoCore-API to detect when it is in use and make the bitbanged SPI code use the `SPISettings` class from ArduinoCore-API in this case.
@facchinmfacchinm merged commitc9ba075 intoarduino:mainNov 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@facchinmfacchinmfacchinm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@per1234@facchinm

[8]ページ先頭

©2009-2025 Movatter.jp