Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Updateextract to 4.0.0 and golang to 1.23#990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 3 commits intomainfromupdate-extract-lib
Aug 29, 2024
Merged

Conversation

@cmaglie
Copy link
Member

@cmagliecmaglie commentedAug 29, 2024•
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among thePull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce?
Updates:

  • go to version 1.23
  • extract to version 4.0.0

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information:

@cmagliecmaglie requested a review fromumbynosAugust 29, 2024 09:01
@codecov-commenter
Copy link

codecov-commenter commentedAug 29, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.85%. Comparing base(fb06ef3) to head(9959910).

Additional details and impacted files
@@           Coverage Diff           @@##             main     #990   +/-   ##=======================================  Coverage   20.85%   20.85%           =======================================  Files          42       42             Lines        2570     2570           =======================================  Hits          536      536             Misses       1949     1949             Partials       85       85
FlagCoverage Δ
unit20.85% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@alessio-peruginialessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Why not upgrade directly to go 1.23? 🤔

@cmaglie
Copy link
MemberAuthor

LGTM. Why not upgrade directly to go 1.23? 🤔

Yes, why... I've updated to 1.23 :-)

umbynos reacted with hooray emoji

@cmagliecmaglie changed the titleUpdateextract to 4.0.0 and golang to 1.22Updateextract to 4.0.0 and golang to 1.23Aug 29, 2024
@cmagliecmaglie self-assigned thisAug 29, 2024
@cmagliecmaglie added topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project labelsAug 29, 2024
@cmagliecmaglie merged commit6f9025e intomainAug 29, 2024
@cmagliecmaglie deleted the update-extract-lib branchAugust 29, 2024 09:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@umbynosumbynosAwaiting requested review from umbynos

@XaytonXaytonAwaiting requested review from Xayton

@MatteoPologrutoMatteoPologrutoAwaiting requested review from MatteoPologruto

1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmagliecmaglie

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmaglie@codecov-commenter@alessio-perugini
[8]ページ先頭
©2009-2025 Movatter.jp